This repository was archived by the owner on Sep 25, 2023. It is now read-only.
Banned users can no longer enter marbles or chat #237
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qaomen
suggested changes
Jun 21, 2019
There was a problem hiding this comment.
Banning is a trickier thing than I thought, like you mentioned.
I'd like to see that users are notified in the client if they are banned, since there's no feedback given at the moment. But since it wasn't part of the acceptance criteria, I'll leave it to you whether to address that now or later. We'll likely have to take a closer look at moderating in general, anyway.
@Qaomen Heck, I thought about it during testing but then forgot again! I'll add it. |
Zemanzo
force-pushed
the
feature/banned-users
branch
from
a72f2c3 to
9587bd2
Compare
Qaomen
approved these changes
Jun 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That said, banning users can be tricky. If they only enter through the embed and are not in the server itself, it might be impossible to get their ID (for mods, at least) and thus being impossible to ban anyway. This could be solved by adding a bot command that fetches ID by user name (something for #233?)
Closes #166